Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7995 Raise node version to 22 #5332

Merged
merged 7 commits into from
Nov 19, 2024
Merged

BC-7995 Raise node version to 22 #5332

merged 7 commits into from
Nov 19, 2024

Conversation

dyedwiper
Copy link
Contributor

@dyedwiper dyedwiper commented Nov 8, 2024

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-7995

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Member

@mamutmk5 mamutmk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a but at /schulcloud-server/scripts/secret.js what make the api-init job fail

/schulcloud-server/node_modules/crypto-js/core.js:335
	            words.length = Math.ceil(sigBytes / 4);
	                         ^

RangeError: Invalid array length
    at WordArray.init.clamp (/schulcloud-server/node_modules/crypto-js/core.js:335:27)
    at WordArray.init.concat (/schulcloud-server/node_modules/crypto-js/core.js:300:19)


    at Object.pad (/schulcloud-server/node_modules/crypto-js/cipher-core.js:417:19)
    at Object._doFinalize (/schulcloud-server/node_modules/crypto-js/cipher-core.js:498:26)
    at Object.finalize (/schulcloud-server/node_modules/crypto-js/cipher-core.js:163:44)
    at Object.encrypt (/schulcloud-server/node_modules/crypto-js/cipher-core.js:685:41)
    at Object.encrypt (/schulcloud-server/node_modules/crypto-js/cipher-core.js:848:58)
    at Object.encrypt (/schulcloud-server/node_modules/crypto-js/cipher-core.js:201:59)
    at Object.<anonymous> (/schulcloud-server/scripts/secret.js:17:25)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)

Node.js v22.11.0

@dyedwiper dyedwiper merged commit 146f6a0 into main Nov 19, 2024
77 checks passed
@dyedwiper dyedwiper deleted the BC-7995-node-22 branch November 19, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants