Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-8424 Fix KNL job configurations #5345

Merged
merged 24 commits into from
Nov 27, 2024
Merged

BC-8424 Fix KNL job configurations #5345

merged 24 commits into from
Nov 27, 2024

Conversation

CeEv
Copy link
Contributor

@CeEv CeEv commented Nov 18, 2024 •
edited
Loading

Description

https://ticketsystem.dbildungscloud.de/browse/BC-8424

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@CeEv CeEv self-assigned this Nov 18, 2024
bischofmax
bischofmax reviewed Nov 21, 2024
View reviewed changes
apps/server/src/modules/deletion-console/deletion-client/deletion.client.ts Outdated Show resolved Hide resolved
apps/server/src/modules/deletion-console/deletion-client/deletion.client.ts Outdated Show resolved Hide resolved
apps/server/src/modules/deletion-console/deletion-client/deletion.client.ts Outdated Show resolved Hide resolved
apps/server/src/modules/deletion-console/deletion.config.ts
const config: DeletionConsoleConfig = {
ADMIN_API_CLIENT_BASE_URL: Configuration.get('ADMIN_API_CLIENT__BASE_URL') as string,
ADMIN_API_CLIENT_API_KEY: Configuration.get('ADMIN_API_CLIENT__API_KEY') as string,
AVAILABLE_LANGUAGES: (Configuration.get('I18N__AVAILABLE_LANGUAGES') as string).split(',') as LanguageType[],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das ja spannend

apps/server/src/modules/idp-console/idp-console.config.ts Show resolved Hide resolved
apps/server/src/shared/common/defaultMikroOrmOptions.ts Show resolved Hide resolved
@CeEv CeEv force-pushed the BC-8424-fix-knl-job-configurations branch from b9d8344 to c1c7027 Compare November 27, 2024 07:32
@CeEv CeEv enabled auto-merge (squash) November 27, 2024 09:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@CeEv CeEv merged commit 02f404f into main Nov 27, 2024
77 checks passed
@CeEv CeEv deleted the BC-8424-fix-knl-job-configurations branch November 27, 2024 10:13
HKayed pushed a commit that referenced this pull request Nov 27, 2024
@CeEv @HKayed
BC-8424 Fix KNL job configurations (#5345)
ebed3fa 
* Move defaultMirkoOrmOptions to shared, to avoid implicit importing the server code by using it.
* Fix configuration for idp-console and deletion-console module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bischofmax bischofmax bischofmax left review comments

@bergatco bergatco bergatco approved these changes

Assignees

@CeEv CeEv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CeEv @bischofmax @bergatco