Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2103 update media activations #5364

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

N21-2103 update media activations #5364

wants to merge 66 commits into from
+2,209 −203

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Nov 28, 2024 •
edited by GordonNicholasCap
Loading

Description

  • add new cron-job to fetch and sync licenses from VIDIS
  • add new strategy for saving licenses from VIDIS

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sdinkov sdinkov mentioned this pull request Dec 4, 2024
Open
1 task
sdinkov and others added 17 commits December 4, 2024 11:45
@sdinkov
rename role
69f3295
@sdinkov
update job definition
3a72046
@sdinkov
Merge branch 'main' into N21-2103-update-media-activations
80f9e23
@mrikallab
N21-2103 mediasource module imports
f79a88b
@mrikallab
Merge branch 'main' into N21-2103-update-media-activations
186ce64 
# Conflicts:
#	apps/server/src/modules/server/server.module.ts
#	apps/server/src/shared/domain/entity/all-entities.ts
@sdinkov
update job scheduling
ade04ee
@mrikallab
Merge remote-tracking branch 'origin/N21-2103-update-media-activation…
3638343 
…s' into N21-2103-update-media-activations

# Conflicts:
#	apps/server/src/modules/server/server.module.ts
@mrikallab
Merge remote-tracking branch 'origin/N21-2103-update-media-activation…
cf0143b 
…s' into N21-2103-update-media-activations
@sdinkov
test scheduling
82e5614
@sdinkov
format job
3dc4521
@sdinkov
update job
d468f02
@sdinkov
update job formatting
a9643b8
@sdinkov
update job: add deployment and service
2bf9f64
@sdinkov
update vidis sync job
294696c
@sdinkov
update vidis job
2933de5
@sdinkov
update cronjob
c693c61
@sdinkov
update vidis job
23bfe2d
mamutmk5
mamutmk5 requested changes Dec 5, 2024
View reviewed changes
ansible/roles/media-licenses/defaults/main.yml Outdated Show resolved Hide resolved
ansible/roles/media-licenses/tasks/main.yml Outdated Show resolved Hide resolved
...ble/roles/media-licenses/templates/vidis-media-activation-data-sync-cronjob-configmap.yml.j2 Outdated Show resolved Hide resolved
...ble/roles/media-licenses/templates/vidis-media-activation-data-sync-cronjob-configmap.yml.j2 Outdated Show resolved Hide resolved
...ble/roles/media-licenses/templates/vidis-media-activation-data-sync-cronjob-configmap.yml.j2 Outdated Show resolved Hide resolved
ansible/roles/media-licenses/templates/vidis-media-activation-data-sync-cronjob.yml.j2 Outdated Show resolved Hide resolved
ansible/roles/media-licenses/templates/vidis-media-activation-data-sync-cronjob.yml.j2 Outdated Show resolved Hide resolved
ansible/roles/media-licenses/templates/vidis-media-activation-data-sync-cronjob.yml.j2 Outdated Show resolved Hide resolved
ansible/roles/media-licenses/templates/vidis-media-activation-data-sync-deployment.yml.j2 Outdated Show resolved Hide resolved
ansible/roles/media-licenses/templates/vidis-media-activation-data-sync-service.yml.j2 Outdated Show resolved Hide resolved
mamutmk5
mamutmk5 reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@mamutmk5 mamutmk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not shour if you shoud write it like this as an console app or if you shoud write it like https://github.com/hpi-schul-cloud/schulcloud-server/blob/main/apps/server/src/apps/deletion-console.app.ts for example as console app, please ask the architects about it.

@sdinkov
Copy link
Contributor

sdinkov commented Dec 13, 2024

I'm not shour if you shoud write it like this as an console app or if you shoud write it like https://github.com/hpi-schul-cloud/schulcloud-server/blob/main/apps/server/src/apps/deletion-console.app.ts for example as console app, please ask the architects about it.

yes, I saw this, and it is cleaner, butt ... the task mentions " infra/sync module" explicitly as the implementation target module, we'll look into it nevertheless, thx

@sdinkov sdinkov dismissed mamutmk5’s stale review December 18, 2024 15:47

as requested by architect

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
34 Uncovered Lines on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamutmk5 mamutmk5 mamutmk5 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrikallab @sdinkov @mamutmk5 @GordonNicholasCap