Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8499 validate tldraw config in forRoot for boardcollabmodule #5384

Closed
wants to merge 1 commit into from

Conversation

Loki-Afro
Copy link
Member

if you do not pull the config to the forroot it does not get validated. if you config is not validated it gets to process.env as a fallback in process.env everything is a string, thus a thought to be boolean will be "false" resulting in if ("false") to be true

in this particular case, it was WITH_TLDRAW2 that lead to this issue

Description

Links to Tickets or other pull requests

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

if you do not pull the config to the forroot it does not get validated.
if you config is not validated it gets to process.env as a fallback
in process.env everything is a string, thus a thought to be boolean will
be "false" resulting in if ("false") to be true

in this particular case, it was WITH_TLDRAW2 that lead to this issue
@Loki-Afro Loki-Afro closed this Dec 5, 2024
@Loki-Afro Loki-Afro deleted the bc-8499 branch December 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant