Add ansible #18
Closed
Add ansible #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bn-pass
suggested changes
Aug 8, 2023
…chul-cloud/tldraw-client into BC-4256-Integration-tldraw
bn-pass
suggested changes
Aug 23, 2023
| @@ -7,7 +7,7 @@ jobs: | |||
| clean: | |||
| permissions: | |||
| contents: read | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/clean_workflow.yml@main | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/clean_workflow.yml@BC-4256-Integration-tldraw | |||
There was a problem hiding this comment.
Please change the branch reference once the dof_app_deploy repo changes will be merged to its main branch before merging this change.
| @@ -68,13 +68,14 @@ jobs: | |||
| needs: | |||
| - build_and_push | |||
| - branch_name | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/deploy.yml@main | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/deploy.yml@BC-4256-Integration-tldraw | |||
There was a problem hiding this comment.
Same here (change it to main).
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es5", | |||
| "target": "esnext", | |||
There was a problem hiding this comment.
I would prefer putting some concrete ES version here, but as I can see it's the same in the Vue client so if you want to keep it consistent across the project repos or you have some other reason for that, it's fine for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review