Add group member count to item permission dropdown

app/controllers/groups_controller.rb

@@ -9,11 +9,12 @@ def index
   end
 
   def all
-    personal_groups = Group.where(tag: :personal_group)
+    everyone_group = Group.where(tag: :everyone_group)
+    generic_groups = Group.where(tag: nil)
 
-    respond_to do |format|
-      format.json { render json: Group.all - personal_groups }
-    end
+    returned_groups = everyone_group + generic_groups
+
+    render json: returned_groups
   end
 
   # GET /groups/1/edit

app/models/group.rb

@@ -30,4 +30,18 @@ def self.owner_groups(item_id)
       WHERE id IN (SELECT group_id FROM permissions WHERE item_id = :item_id AND permission_type = :permission_type)",
                  { item_id: item_id, permission_type: "2" }]
   end
+
+  def user_count
+    users.length
+  end
+
+  def user_count_string
+    "#{user_count} #{I18n.t('group_member', count: user_count)}"
+  end
+
+  def as_json(options)
+    super(options.merge({
+                          methods: [:user_count, :user_count_string]
+                        }))
+  end
 end

app/views/items/_item_type_form.html.erb

@@ -52,7 +52,7 @@
       <div class="row mt-2" v-for="(permission, i) in permissions">
         <div class="col">
           <select :name="`permission_${i}_group_id`" :id="`permission_select_${i}_group_id`" class="form-select" required v-model="permission.groupId">
-            <option :value="group.id" v-for="group in groups">{{group.name}}</option>
+            <option :value="group.id" v-for="group in groups">{{group.name}} ({{ group.user_count_string }})</option>
           </select>
         </div>
         <div class="col">

spec/views/items/edit.html.erb_spec.rb

@@ -27,6 +27,14 @@
     end
   end
 
+  it "contains a member counter" do
+    item = FactoryBot.create(:other)
+    assign(:item, item)
+    render
+
+    expect(response).to have_text("'member' : 'members'")
+  end
+
   [:book, :movie, :game, :other].each do |item_type|
     it "renders correct attributes for item type #{item_type}" do
       item = FactoryBot.create(item_type)