Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexibus/#379/teams view as tiles #401

Merged
merged 13 commits into from
Jan 20, 2018
Merged

Flexibus/#379/teams view as tiles #401

merged 13 commits into from
Jan 20, 2018

Conversation

emanuel-metzenthin
Copy link

@emanuel-metzenthin emanuel-metzenthin commented Jan 19, 2018 •
edited by JakobEdding
Loading

Closes #379.

@ghost ghost added the review label Jan 19, 2018
@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6625ac4 on flexibus/#379/teams-page-design into 605e9fb on dev.

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1e22f75 on flexibus/#379/teams-page-design into 305a831 on dev.

usame-algan
usame-algan reviewed Jan 19, 2018
View reviewed changes
app/assets/stylesheets/tile.css
@@ -0,0 +1,49 @@
@media screen and (min-width : 800px) {
.tile-wrapper {
display: grid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we handle browser support? See https://caniuse.com/#feat=css-grid
Do we have a fallback to flexbox or something similar?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grid is not compatible with Opera Mini and UC Browser for Android. All major browsers support it. So I guess we're fine :).

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 06f9595 on flexibus/#379/teams-page-design into 305a831 on dev.

usame-algan
usame-algan requested changes Jan 19, 2018
View reviewed changes
app/views/application/_tile_template.html.erb Outdated
@@ -0,0 +1,11 @@
<div onclick="location.href='<%= destination_path%>';" class="tile">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work if Javascript is disabled in the Browser. Could use an <a> Tag with absolute positioning to achieve the same result.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think many features are dependent of JS already ;). Nonetheless I changed it, good point. Could you accept?

@coveralls
Copy link

coveralls commented Jan 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6c388a6 on flexibus/#379/teams-page-design into 7390217 on dev.

@coveralls
Copy link

coveralls commented Jan 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 768305d on flexibus/#379/teams-page-design into f099edd on dev.

@coveralls
Copy link

coveralls commented Jan 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 768305d on flexibus/#379/teams-page-design into f099edd on dev.

@emanuel-metzenthin emanuel-metzenthin merged commit 5366703 into dev Jan 20, 2018
@ghost ghost removed the review label Jan 20, 2018
@deeps96 deeps96 mentioned this pull request Jan 30, 2018
Merged
@JakobEdding JakobEdding changed the title Flexibus/#379/teams page design Flexibus/#379/teams view as tiles Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usame-algan usame-algan usame-algan approved these changes

@Blubl Blubl Awaiting requested review from Blubl

@jcremerius jcremerius Awaiting requested review from jcremerius

Assignees

@emanuel-metzenthin emanuel-metzenthin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emanuel-metzenthin @coveralls @usame-algan