-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some functions and classes to resolve memory usage problem #64
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
I added docs in README.md to explain how to deal with memory issues. I set the minimal required version of openfhe-julia to 0.3.4 because new functions were added and OpenFHE.jl crashes with older versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions for the memory hint in the README. Please make sure that I didn't write anything wrong and feel free to correct anything that is too hard to understand
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR contains docs and tests for new functionalities wrapped in hpsc-lab/openfhe-julia#61.
PR should be merged after hpsc-lab/openfhe-julia#61 gets merged and new openfhe-julia release gets published