Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions and classes to resolve memory usage problem #64

Merged
merged 17 commits into from
Sep 3, 2024

Conversation

ArseniyKholod
Copy link
Collaborator

This PR contains docs and tests for new functionalities wrapped in hpsc-lab/openfhe-julia#61.

PR should be merged after hpsc-lab/openfhe-julia#61 gets merged and new openfhe-julia release gets published

Arseniy Kholod and others added 2 commits August 2, 2024 10:14
@ArseniyKholod ArseniyKholod marked this pull request as draft August 2, 2024 09:40
src/documentation.jl Outdated Show resolved Hide resolved
src/documentation.jl Outdated Show resolved Hide resolved
src/documentation.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/OpenFHE.jl 100.00% <ø> (ø)

@ArseniyKholod
Copy link
Collaborator Author

ArseniyKholod commented Aug 31, 2024

I added docs in README.md to explain how to deal with memory issues. I set the minimal required version of openfhe-julia to 0.3.4 because new functions were added and OpenFHE.jl crashes with older versions.

@ArseniyKholod ArseniyKholod requested a review from sloede August 31, 2024 10:08
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions for the memory hint in the README. Please make sure that I didn't write anything wrong and feel free to correct anything that is too hard to understand

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sloede sloede merged commit 1d058a4 into hpsc-lab:main Sep 3, 2024
12 checks passed
@ArseniyKholod ArseniyKholod deleted the memory_issue branch September 3, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants