Skip to content

Commit

Permalink
Repeat getHistory request if some new server messages aren't received.
Browse files Browse the repository at this point in the history
  • Loading branch information
@levlam
levlam committed Jul 29, 2021
1 parent c1d69fc commit bc85442
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 22 deletions.
68 changes: 48 additions & 20 deletions td/telegram/MessagesManager.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1928,6 +1928,7 @@ class GetHistoryQuery final : public Td::ResultHandler {
Promise<Unit> promise_;
DialogId dialog_id_;
MessageId from_message_id_;
MessageId old_last_new_message_id_;
int32 offset_;
int32 limit_;
bool from_the_end_;
Expand All @@ -1936,7 +1937,8 @@ class GetHistoryQuery final : public Td::ResultHandler {
explicit GetHistoryQuery(Promise<Unit> &&promise) : promise_(std::move(promise)) {
}

void send(DialogId dialog_id, MessageId from_message_id, int32 offset, int32 limit) {
void send(DialogId dialog_id, MessageId from_message_id, MessageId old_last_new_message_id, int32 offset,
int32 limit) {
auto input_peer = td->messages_manager_->get_input_peer(dialog_id, AccessRights::Read);
if (input_peer == nullptr) {
LOG(ERROR) << "Can't get chat history in " << dialog_id << " because doesn't have info about the chat";
Expand All @@ -1946,21 +1948,23 @@ class GetHistoryQuery final : public Td::ResultHandler {

dialog_id_ = dialog_id;
from_message_id_ = from_message_id;
old_last_new_message_id_ = old_last_new_message_id;
offset_ = offset;
limit_ = limit;
from_the_end_ = false;
send_query(G()->net_query_creator().create(telegram_api::messages_getHistory(
std::move(input_peer), from_message_id.get_server_message_id().get(), 0, offset, limit, 0, 0, 0)));
}

void send_get_from_the_end(DialogId dialog_id, int32 limit) {
void send_get_from_the_end(DialogId dialog_id, MessageId old_last_new_message_id, int32 limit) {
auto input_peer = td->messages_manager_->get_input_peer(dialog_id, AccessRights::Read);
if (input_peer == nullptr) {
LOG(ERROR) << "Can't get chat history because doesn't have info about the chat";
return promise_.set_error(Status::Error(500, "Have no info about the chat"));
}

dialog_id_ = dialog_id;
old_last_new_message_id_ = old_last_new_message_id;
offset_ = 0;
limit_ = limit;
from_the_end_ = true;
Expand All @@ -1977,17 +1981,17 @@ class GetHistoryQuery final : public Td::ResultHandler {
auto info = td->messages_manager_->on_get_messages(result_ptr.move_as_ok(), "GetHistoryQuery");
td->messages_manager_->get_channel_difference_if_needed(
dialog_id_, std::move(info),
PromiseCreator::lambda([td = td, dialog_id = dialog_id_, from_message_id = from_message_id_, offset = offset_,
limit = limit_, from_the_end = from_the_end_,
PromiseCreator::lambda([td = td, dialog_id = dialog_id_, from_message_id = from_message_id_,
old_last_new_message_id = old_last_new_message_id_, offset = offset_, limit = limit_,
from_the_end = from_the_end_,
promise = std::move(promise_)](Result<MessagesManager::MessagesInfo> &&result) mutable {
if (result.is_error()) {
promise.set_error(result.move_as_error());
} else {
auto info = result.move_as_ok();
// TODO use info.total_count, info.pts
td->messages_manager_->on_get_history(dialog_id, from_message_id, offset, limit, from_the_end,
std::move(info.messages));
promise.set_value(Unit());
td->messages_manager_->on_get_history(dialog_id, from_message_id, old_last_new_message_id, offset, limit,
from_the_end, std::move(info.messages), std::move(promise));
}
}));
}
Expand Down Expand Up @@ -9249,18 +9253,34 @@ void MessagesManager::on_get_messages(vector<tl_object_ptr<telegram_api::Message
}
}

void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_id, int32 offset, int32 limit,
bool from_the_end, vector<tl_object_ptr<telegram_api::Message>> &&messages) {
void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_id, MessageId old_last_new_message_id,
int32 offset, int32 limit, bool from_the_end,
vector<tl_object_ptr<telegram_api::Message>> &&messages, Promise<Unit> &&promise) {
LOG(INFO) << "Receive " << messages.size() << " history messages " << (from_the_end ? "from the end " : "") << "in "
<< dialog_id << " from " << from_message_id << " with offset " << offset << " and limit " << limit;
CHECK(-limit < offset && offset <= 0);
CHECK(offset < 0 || from_the_end);
CHECK(!from_message_id.is_scheduled());

Dialog *d = get_dialog(dialog_id);

MessageId last_received_message_id = messages.empty() ? MessageId() : get_message_id(messages[0], false);
if (d != nullptr && old_last_new_message_id < d->last_new_message_id &&
(from_the_end || old_last_new_message_id < from_message_id) &&
last_received_message_id < d->last_new_message_id) {
// new server messages were added to the dialog since the request was sent, but weren't received
// they should have been received, so we must repeat the request to get them
if (from_the_end) {
get_history_from_the_end_impl(d, false, false, std::move(promise));
} else {
get_history_impl(d, from_message_id, offset, limit, false, false, std::move(promise));
}
return;
}

// the server can return less messages than requested if some of messages are deleted during request
// but if it happens, it is likely that there are no more messages on the server
bool have_full_history = from_the_end && narrow_cast<int32>(messages.size()) < limit && messages.size() <= 1;
Dialog *d = get_dialog(dialog_id);

if (messages.empty()) {
if (d != nullptr) {
Expand All @@ -9281,6 +9301,7 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_

// be aware that in some cases an empty answer may be returned, because of the race of getHistory and deleteMessages
// and not because there are no more messages
promise.set_value(Unit());
return;
}

Expand All @@ -9298,6 +9319,7 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
}
// TODO move to ERROR
LOG(FATAL) << error;
promise.set_value(Unit());
return;
}
cur_message_id = message_id;
Expand All @@ -9310,7 +9332,6 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
// be aware that any subset of the returned messages may be already deleted and returned as MessageEmpty
bool is_channel_message = dialog_id.get_type() == DialogType::Channel;
MessageId first_added_message_id;
MessageId last_received_message_id = get_message_id(messages[0], false);
MessageId last_added_message_id;
bool have_next = false;

Expand All @@ -9337,15 +9358,15 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
}

if (from_the_end && d != nullptr) {
auto last_server_message_id = get_message_id(messages[0], false);
// delete all server messages with ID > last_server_message_id
// delete all server messages with ID > last_received_message_id
// there were no new messages received after the getHistory request was sent, so they are already deleted message
vector<MessageId> message_ids;
find_newer_messages(d->messages.get(), last_server_message_id, message_ids);
find_newer_messages(d->messages.get(), last_received_message_id, message_ids);
if (!message_ids.empty()) {
bool need_update_dialog_pos = false;
vector<int64> deleted_message_ids;
for (auto message_id : message_ids) {
CHECK(message_id > last_server_message_id);
CHECK(message_id > last_received_message_id);
if (message_id.is_server()) {
auto message = delete_message(d, message_id, true, &need_update_dialog_pos, "on_get_gistory 1");
CHECK(message != nullptr);
Expand All @@ -9360,10 +9381,10 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
send_update_delete_messages(dialog_id, std::move(deleted_message_ids), true, false);

message_ids.clear();
find_newer_messages(d->messages.get(), last_server_message_id, message_ids);
find_newer_messages(d->messages.get(), last_received_message_id, message_ids);
}

// connect all messages with ID > last_server_message_id
// connect all messages with ID > last_received_message_id
for (size_t i = 0; i + 1 < message_ids.size(); i++) {
auto m = get_message(d, message_ids[i]);
CHECK(m != nullptr);
Expand All @@ -9372,6 +9393,8 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
attach_message_to_next(d, message_ids[i], "on_get_history 3");
}
}

have_next = true;
}
}

Expand Down Expand Up @@ -9420,6 +9443,7 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
}

if (d == nullptr) {
promise.set_value(Unit());
return;
}

Expand Down Expand Up @@ -9546,6 +9570,7 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
}
}
}
promise.set_value(Unit());
}

vector<DialogId> MessagesManager::get_peers_dialog_ids(vector<tl_object_ptr<telegram_api::Peer>> &&peers) {
Expand Down Expand Up @@ -20309,6 +20334,7 @@ tl_object_ptr<td_api::messages> MessagesManager::get_dialog_history(DialogId dia
while (*p != nullptr && messages.size() < static_cast<size_t>(limit)) {
messages.push_back(get_message_object(dialog_id, *p));
from_message_id = (*p)->message_id;
from_the_end = false;
--p;
}
}
Expand Down Expand Up @@ -22327,13 +22353,15 @@ void MessagesManager::get_history_from_the_end_impl(const Dialog *d, bool from_d
std::move(promise));
}));
} else {
if (only_local || dialog_id.get_type() == DialogType::SecretChat) {
if (only_local || dialog_id.get_type() == DialogType::SecretChat || d->last_message_id.is_valid()) {
// if last message is known, there are no reasons to get message history from server from the end
promise.set_value(Unit());
return;
}

LOG(INFO) << "Get history from the end of " << dialog_id << " from server";
td_->create_handler<GetHistoryQuery>(std::move(promise))->send_get_from_the_end(dialog_id, limit);
td_->create_handler<GetHistoryQuery>(std::move(promise))
->send_get_from_the_end(dialog_id, d->last_new_message_id, limit);
}
}

Expand Down Expand Up @@ -22385,7 +22413,7 @@ void MessagesManager::get_history_impl(const Dialog *d, MessageId from_message_i
LOG(INFO) << "Get history in " << dialog_id << " from " << from_message_id << " with offset " << offset
<< " and limit " << limit << " from server";
td_->create_handler<GetHistoryQuery>(std::move(promise))
->send(dialog_id, from_message_id.get_next_server_message_id(), offset, limit);
->send(dialog_id, from_message_id.get_next_server_message_id(), d->last_new_message_id, offset, limit);
}
}

Expand Down
5 changes: 3 additions & 2 deletions td/telegram/MessagesManager.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,9 @@ class MessagesManager final : public Actor {
void on_get_messages(vector<tl_object_ptr<telegram_api::Message>> &&messages, bool is_channel_message,
bool is_scheduled, const char *source);

void on_get_history(DialogId dialog_id, MessageId from_message_id, int32 offset, int32 limit, bool from_the_end,
vector<tl_object_ptr<telegram_api::Message>> &&messages);
void on_get_history(DialogId dialog_id, MessageId from_message_id, MessageId old_last_new_message_id, int32 offset,
int32 limit, bool from_the_end, vector<tl_object_ptr<telegram_api::Message>> &&messages,
Promise<Unit> &&promise);

void on_get_public_dialogs_search_result(const string &query, vector<tl_object_ptr<telegram_api::Peer>> &&my_peers,
vector<tl_object_ptr<telegram_api::Peer>> &&peers);
Expand Down

0 comments on commit bc85442

Please sign in to comment.