Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OSX dock options #151

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Adds OSX dock options #151

merged 2 commits into from
Jul 4, 2017

Conversation

colindean
Copy link
Contributor

I got tired of seeing the Java icon in my dock. This little change adds a nice icon.

However, I can't quite figure out where to put the icon so that it gets included in the release archive. I can't quite figure out how you're producing the archive, either! So, here's the image. Maybe you can put it in place so that it is included in the same directory as abandon_gui.sh.

ledger

colindean added 2 commits July 3, 2017 13:09
This way, it retains the original name
@colindean
Copy link
Contributor Author

The icon is public domain from the Primary icon set for KDE, apparently.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.39% when pulling 63627b3 on colindean:osx-dock into e42ff29 on hrj:master.

@hrj hrj merged commit 7fa8773 into hrj:master Jul 4, 2017
@hrj
Copy link
Owner

hrj commented Jul 4, 2017

Thanks.

I am creating the releases manually by copying files and zipping them. Would be nice to automate that someday.

@colindean
Copy link
Contributor Author

colindean commented Jul 4, 2017 via email

@hrj
Copy link
Owner

hrj commented Jul 5, 2017

That is a definition of hell, for me at least. I’d volunteer to do it, but I don’t know sbt well enough to do it without considerable research and time investment. I’m a Gradle guy right now. If you create the issue and throw some links to examples in there, I can probably do it when I get a chance.

Created an issue here: #152

A simple bash script will be fine with me.

@colindean colindean deleted the osx-dock branch July 10, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants