Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OrdinalClass #37

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Added OrdinalClass #37

merged 1 commit into from
Feb 19, 2024

Conversation

imrannasrullah
Copy link

Added the "OrdinalScale" class in the core.py file. However, I modified the issues requesr slightly, so that the "statistics" and "distribution" class variables are instead set using class functions that call the respectively called functions

@SimonMolinsky
Copy link
Member

Hi @imrannasrullah ,

For me, it's ok, thanks for the methods - I wonder If they will persist, but at this moment, we let them be there ;) Two more things:

  1. Could you create a simple docstring below class name with the list of Parameters and Attributes following numpy-style docs: https://github.com/hs3city/ordinal-scale-stats-py/blob/main/docs/dev-docstrings.md

  2. I will set you as a contributor to this block of code within a script (core.py), but I need to know if you want to use only your Github handle OR your Github handle + your name and surname? If the second option, then let me know your full name (like people here, on the top of a file: https://github.com/hs3city/ordinal-scale-stats-py/blob/main/src/allison_foster.py)

Thanks!

@imrannasrullah
Copy link
Author

Appreciate it, but it's fine! I was testing out my ability for first-time contributions since I'm new to Git, so I just wanted to try a first-issue. The code that I've pulled worked wonderfully, so I think that's experience enough for me.

Thanks so much!

@SimonMolinsky SimonMolinsky changed the base branch from main to 36-feature-ordinalscale-class February 19, 2024 10:16
@SimonMolinsky SimonMolinsky merged commit b1453dd into hs3city:36-feature-ordinalscale-class Feb 19, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants