Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a lightbulb has fullcolorsupport #105

Merged
merged 4 commits into from
Jan 26, 2025

Conversation

flabbamann
Copy link
Contributor

If fullcolorsupport is set, we can use setunmappedcolor for free color selection. This was not documented at the time I implemented the free color selection.

@coveralls
Copy link

coveralls commented Oct 25, 2024

Coverage Status

coverage: 96.814% (+0.007%) from 96.807%
when pulling 2ffa257 on flabbamann:fullcolorsupport
into 39b62fc on hthiery:master.

@mib1185 mib1185 marked this pull request as draft January 19, 2025 12:29
@flabbamann flabbamann marked this pull request as ready for review January 20, 2025 14:04
@flabbamann flabbamann requested a review from mib1185 January 22, 2025 20:18
Copy link
Collaborator

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @flabbamann 👍

@mib1185
Copy link
Collaborator

mib1185 commented Jan 25, 2025

there are conflicts, please resolve them before we can merge this PR

@flabbamann
Copy link
Contributor Author

flabbamann commented Jan 26, 2025

Hm, Githubs new merge experience shows no conflicts, the classic merge experience does...
Rebased to master 🙂.

@mib1185 mib1185 merged commit b277f70 into hthiery:master Jan 26, 2025
13 checks passed
@flabbamann flabbamann deleted the fullcolorsupport branch January 26, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants