Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1024 and #1025 #1030

Closed
wants to merge 2 commits into from
Closed

Fix for #1024 and #1025 #1030

wants to merge 2 commits into from

Conversation

fcr
Copy link
Collaborator

@fcr fcr commented Jan 21, 2025

This branch builds successfully on all conda and uv Pythons 3.12 and greater but has only been tested on MacOS Sequioa.
One C++ unit test and three Python unit tests fail so this PR is only provisional so that others can test it on other platforms.

@fcr fcr mentioned this pull request Jan 21, 2025
Merged
dkeeney
dkeeney reviewed Jan 21, 2025
View reviewed changes
Copy link

@dkeeney dkeeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, You managed to fix it with so few changes by keeping setuptools.
I spent months rewriting it so it worked with scikit-build-core and all of the new tools. Is mine better....don't know. We need to talk about it.

pyproject.toml Show resolved Hide resolved
@fcr
Copy link
Collaborator Author

fcr commented Jan 26, 2025

Replaced by #1029

@fcr fcr closed this Jan 26, 2025
@fcr fcr deleted the python312+ branch January 26, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkeeney dkeeney dkeeney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcr @dkeeney