photo#453

- AlbumCreateFragment, FacebooFragment, PhotoDetailsEditFragment, TwitterFragment: replaced dismiss call with the dismissAllowingStateLoss call to avoid possible IllegalStateException when home button is pressed http://stackoverflow.com/a/10275071/527759
httpdispatch · Jun 18, 2013 · fdff74a · fdff74a
1 parent f84f795
commit fdff74a
Showing 4 changed files with 15 additions and 16 deletions.
diff --git a/app/src/com/trovebox/android/app/AlbumCreateFragment.java b/app/src/com/trovebox/android/app/AlbumCreateFragment.java
@@ -65,7 +65,7 @@ public void run() {
                 Dialog dialog = AlbumCreateFragment.this.getDialog();
                 if (dialog != null && dialog.isShowing())
                 {
-                    AlbumCreateFragment.this.dismiss();
+                    AlbumCreateFragment.this.dismissAllowingStateLoss();
                 }
             }
         };

diff --git a/app/src/com/trovebox/android/app/FacebookFragment.java b/app/src/com/trovebox/android/app/FacebookFragment.java
@@ -145,7 +145,7 @@ public void run() {
         {
             GuiUtils.error(TAG, R.string.errorCouldNotInitFacebookFragment, ex,
                     getActivity());
-            dismiss();
+            dismissAllowingStateLoss();
         }
     }
 
@@ -164,7 +164,7 @@ public void run(Photo photo) {
     private void performFacebookLogout()
     {
         FacebookUtils.logoutRequest(getSupportActivity());
-        dismiss();
+        dismissAllowingStateLoss();
     }
 
     @Override
@@ -303,7 +303,7 @@ protected void onPostExecute(Boolean result)
             Dialog dialog = FacebookFragment.this.getDialog();
             if (dialog != null && dialog.isShowing())
             {
-                FacebookFragment.this.dismiss();
+                FacebookFragment.this.dismissAllowingStateLoss();
             }
         }
     }

diff --git a/app/src/com/trovebox/android/app/PhotoDetailsEditFragment.java b/app/src/com/trovebox/android/app/PhotoDetailsEditFragment.java
@@ -6,14 +6,6 @@
 import org.holoeverywhere.app.Dialog;
 import org.holoeverywhere.widget.Switch;
 
-import com.trovebox.android.app.R;
-import com.trovebox.android.app.common.CommonStyledDialogFragment;
-import com.trovebox.android.app.model.Photo;
-import com.trovebox.android.app.model.utils.PhotoUtils;
-import com.trovebox.android.app.model.utils.TagUtils;
-import com.trovebox.android.app.util.ProgressDialogLoadingControl;
-import com.trovebox.android.app.util.TrackerUtils;
-
 import android.content.Intent;
 import android.os.Bundle;
 import android.view.View;
@@ -22,6 +14,13 @@
 import android.widget.Button;
 import android.widget.EditText;
 
+import com.trovebox.android.app.common.CommonStyledDialogFragment;
+import com.trovebox.android.app.model.Photo;
+import com.trovebox.android.app.model.utils.PhotoUtils;
+import com.trovebox.android.app.model.utils.TagUtils;
+import com.trovebox.android.app.util.ProgressDialogLoadingControl;
+import com.trovebox.android.app.util.TrackerUtils;
+
 /**
  * The view which represents photo details editing functionality
  * 
@@ -149,7 +148,7 @@ public void run() {
                 Dialog dialog = PhotoDetailsEditFragment.this.getDialog();
                 if (dialog != null && dialog.isShowing())
                 {
-                    PhotoDetailsEditFragment.this.dismiss();
+                    PhotoDetailsEditFragment.this.dismissAllowingStateLoss();
                 }
             }
         };

diff --git a/app/src/com/trovebox/android/app/TwitterFragment.java b/app/src/com/trovebox/android/app/TwitterFragment.java
@@ -167,7 +167,7 @@ public void run() {
         {
             GuiUtils.error(TAG, R.string.errorCouldNotInitTwitterFragment, ex,
                     getActivity());
-            dismiss();
+            dismissAllowingStateLoss();
         }
     }
 
@@ -179,7 +179,7 @@ protected void postTweet()
     private void performTwitterLogout()
     {
         TwitterUtils.logout(getActivity());
-        dismiss();
+        dismissAllowingStateLoss();
     }
 
     @Override
@@ -319,7 +319,7 @@ protected void onPostExecute(Boolean result)
             Dialog dialog = TwitterFragment.this.getDialog();
             if (dialog != null && dialog.isShowing())
             {
-                TwitterFragment.this.dismiss();
+                TwitterFragment.this.dismissAllowingStateLoss();
             }
         }
     }