review: Lint (a bit more than this PR is about)

.rubocop/rspec.yml

@@ -4,3 +4,6 @@ RSpec/ExampleLength:
     - hash
     - heredoc
     - method_call
+
+RSpec/MultipleExpectations:
+  Max: 5

.rubocop_todo.yml

@@ -267,30 +267,6 @@ RSpec/InstanceVariable:
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 74
-# Configuration parameters: Max.
-RSpec/MultipleExpectations:
-  Exclude:
-    - 'spec/lib/http/client_spec.rb'
-    - 'spec/lib/http/connection_spec.rb'
-    - 'spec/lib/http/features/auto_deflate_spec.rb'
-    - 'spec/lib/http/headers_spec.rb'
-    - 'spec/lib/http/options/body_spec.rb'
-    - 'spec/lib/http/options/features_spec.rb'
-    - 'spec/lib/http/options/form_spec.rb'
-    - 'spec/lib/http/options/headers_spec.rb'
-    - 'spec/lib/http/options/json_spec.rb'
-    - 'spec/lib/http/options/merge_spec.rb'
-    - 'spec/lib/http/options/proxy_spec.rb'
-    - 'spec/lib/http/redirector_spec.rb'
-    - 'spec/lib/http/response/body_spec.rb'
-    - 'spec/lib/http/response/parser_spec.rb'
-    - 'spec/lib/http/retriable/delay_calculator_spec.rb'
-    - 'spec/lib/http/retriable/performer_spec.rb'
-    - 'spec/lib/http/uri_spec.rb'
-    - 'spec/lib/http_spec.rb'
-    - 'spec/support/http_handling_shared.rb'
-
 # Offense count: 9
 # Configuration parameters: AllowSubject, Max.
 RSpec/MultipleMemoizedHelpers:

spec/lib/http/headers/normalizer_spec.rb

@@ -27,8 +27,8 @@
 
       expect(normalized_headers)
         .to satisfy { |arr| arr.uniq.size == 1 }
-        .and satisfy { |arr| arr.map(&:object_id).uniq.size == normalized_headers.size }
-        .and satisfy { |arr| arr.none?(&:frozen?) }
+        .and(satisfy { |arr| arr.map(&:object_id).uniq.size == normalized_headers.size })
+        .and(satisfy { |arr| arr.none?(&:frozen?) })
     end
 
     it "allocates minimal memory for normalization of the same header" do

spec/lib/http/redirector_spec.rb

@@ -117,12 +117,13 @@ def redirect_response(status, location, set_cookie = {})
         expect(req_cookie).to eq request_cookies.shift
         hops.shift
       end
+
       expect(res.to_s).to eq "bar"
-      cookies = res.cookies.cookies.to_h { |c| [c.name, c.value] }
-      expect(cookies["foo"]).to eq "42"
-      expect(cookies["bar"]).to eq "53"
-      expect(cookies["baz"]).to eq "65"
-      expect(cookies["deleted"]).to eq nil
+      expect(res.cookies.cookies.to_h { |c| [c.name, c.value] }).to eq({
+        "foo" => "42",
+        "bar" => "53",
+        "baz" => "65"
+      })
     end
 
     it "returns original cookies in response" do

spec/lib/http/retriable/performer_spec.rb

@@ -199,7 +199,7 @@ def response(**options)
     end
 
     describe "should_retry option" do
-      it "decides if the request should be retried" do
+      it "decides if the request should be retried" do # rubocop:disable RSpec/MultipleExpectations
         retry_proc = proc do |req, err, res, attempt|
           expect(req).to eq request
           if res