Add .retriable feature to Http - Rebased #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delay by default backs backs off over time * Maximum delay time * Exceptions to retry from * Status codes to retry from * Custom retry logic * Respect Retry-After header if present * on_retry callback
* Less procs & proc building overall * seperate delay calculation into its own class
|
I had some time, so I ended up rebasing and fixing the lint and test errors. @ixti would you mind taking a look again? |
|
That looks amazing! Thank you! Will take me some time reviewing though... :D |
|
@ixti Any luck? |
|
I've been using this in prod for a few months now and so far haven't noticed any issues :) |
tarcieri
approved these changes
Jul 8, 2024
|
Thanks! |
|
@tarcieri any chance we could get a gem version published? we'd greatly benefit having retries built in. |
|
@mylesboone Will cut the release this week. |
|
@ixti any chance we could get the release this week? it would be a massive help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #598 with:
I don't understand the internals super well, but the changes I made off of the original were minor enough to not really change any actual functionality. Tests and cops all pass!