Ignore empty values and expressions to prevent syntax error #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the issue that builders will generate bad SQL statements if empty values and/or expressions are provided.
For instance, if we build SQL like following, we will get a SQL statement with syntax error.
In this PR, if there is no values or expressions provided in
Cond.IN
/Cond.NotIn
/Cond.Some
/Cond.All
/Cond.Any
/Cond.And
/Cond.Or
, the condition will be ignored completely. Thus, the case above will printSELECT c FROM t
with this PR.It's a better solution to address the same issue mentioned in PR #188. cc @ErikBooijMB