Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataarts/dataservice): new resources support for auth management #5383

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
Supports two resources to authorize APP(s) to access API and cancel the authorize permission.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resources support for authorize management.

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/dataarts' TESTARGS='-run=TestAccDataServiceApiAuth_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dataarts -v -run=TestAccDataServiceApiAuth_basic -timeout 360m -parallel 4
=== RUN   TestAccDataServiceApiAuth_basic
=== PAUSE TestAccDataServiceApiAuth_basic
=== CONT  TestAccDataServiceApiAuth_basic
--- PASS: TestAccDataServiceApiAuth_basic (158.51s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dataarts  158.572s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_dataarts_dataservice_api_auth branch from 4d1811c to 02ff2da Compare August 15, 2024 11:22
@Lance52259
Copy link
Contributor Author

make testacc TEST='./huaweicloud/services/acceptance/dataarts' TESTARGS='-run=TestAccDataServiceApiAuthAction_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dataarts -v -run=TestAccDataServiceApiAuthAction_basic -timeout 360m -parallel 4
=== RUN   TestAccDataServiceApiAuthAction_basic
=== PAUSE TestAccDataServiceApiAuthAction_basic
=== CONT  TestAccDataServiceApiAuthAction_basic
--- PASS: TestAccDataServiceApiAuthAction_basic (244.39s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dataarts  244.461s

@Lance52259
Copy link
Contributor Author

make testacc TEST='./huaweicloud/services/acceptance/dataarts' TESTARGS='-run=TestAccDataServiceApiAuth_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dataarts -v -run=TestAccDataServiceApiAuth_basic -timeout 360m -parallel 4
=== RUN   TestAccDataServiceApiAuth_basic
=== PAUSE TestAccDataServiceApiAuth_basic
=== CONT  TestAccDataServiceApiAuth_basic
--- PASS: TestAccDataServiceApiAuth_basic (199.09s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dataarts  199.148s

@Lance52259 Lance52259 force-pushed the br_dataarts_dataservice_api_auth branch from 02ff2da to 40e1967 Compare August 16, 2024 02:58
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Aug 16, 2024
@github-ci-robot github-ci-robot merged commit 7c3d03b into huaweicloud:master Aug 16, 2024
13 checks passed
@Lance52259 Lance52259 deleted the br_dataarts_dataservice_api_auth branch August 16, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants