-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataarts/dataservice): new resources support for auth management #5383
Merged
github-ci-robot
merged 1 commit into
huaweicloud:master
from
Lance52259:br_dataarts_dataservice_api_auth
Aug 16, 2024
Merged
feat(dataarts/dataservice): new resources support for auth management #5383
github-ci-robot
merged 1 commit into
huaweicloud:master
from
Lance52259:br_dataarts_dataservice_api_auth
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 12, 2024
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
Lance52259
force-pushed
the
br_dataarts_dataservice_api_auth
branch
from
August 15, 2024 11:22
4d1811c
to
02ff2da
Compare
|
|
deer-hang
reviewed
Aug 16, 2024
huaweicloud/services/dataarts/resource_huaweicloud_dataarts_dataservice_api_auth.go
Outdated
Show resolved
Hide resolved
deer-hang
reviewed
Aug 16, 2024
huaweicloud/services/dataarts/resource_huaweicloud_dataarts_dataservice_api_auth.go
Outdated
Show resolved
Hide resolved
deer-hang
reviewed
Aug 16, 2024
huaweicloud/services/dataarts/resource_huaweicloud_dataarts_dataservice_api_auth_action.go
Outdated
Show resolved
Hide resolved
Lance52259
force-pushed
the
br_dataarts_dataservice_api_auth
branch
from
August 16, 2024 02:58
02ff2da
to
40e1967
Compare
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Supports two resources to authorize APP(s) to access API and cancel the authorize permission.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<