Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): add new resource identity policy #5380

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Jason-Zhang9309
Copy link
Collaborator

@Jason-Zhang9309 Jason-Zhang9309 commented Aug 12, 2024

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
go test ./huaweicloud/services/acceptance/iam -v -run TestAccIdentityPolicy_basic -timeout 360m -parallel 4
=== RUN   TestAccIdentityPolicy_basic
=== PAUSE TestAccIdentityPolicy_basic
=== CONT  TestAccIdentityPolicy_basic
--- PASS: TestAccIdentityPolicy_basic (32.39s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iam       32.548s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      it's checked, but can't upload the screenshot here

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      it's checked, but can't upload the screenshot here

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Jason-Zhang9309

@github-actions github-actions bot added size/L and removed size/M labels Aug 13, 2024
@Jason-Zhang9309 Jason-Zhang9309 changed the title [WIP]feat(iam): add new resource identity policy feat(iam): add new resource identity policy Aug 13, 2024
@Jason-Zhang9309 Jason-Zhang9309 force-pushed the dev-iam branch 2 times, most recently from 24312a8 to b89b8c2 Compare August 13, 2024 06:23
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Aug 14, 2024
@github-ci-robot github-ci-robot merged commit 93b7e8a into huaweicloud:master Aug 14, 2024
13 checks passed
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-iam branch August 15, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants