Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aom): support dashboard management #5389

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat(aom): support dashboard management #5389

merged 1 commit into from
Aug 21, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Aug 13, 2024 •
edited
Loading

What this PR does / why we need it:
Support dashboard management

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/aom" TESTARGS="-run TestAccDashboard_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/aom -v -run TestAccDashboard_basic -timeout 360m -parallel 4
=== RUN   TestAccDashboard_basic
=== PAUSE TestAccDashboard_basic
=== CONT  TestAccDashboard_basic
--- PASS: TestAccDashboard_basic (130.17s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/aom       130.244s

make testacc TEST="./huaweicloud/services/acceptance/aom" TESTARGS="-run  TestAccDataSourceDashboards_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/aom -v -run  TestAccDataSourceDashboards_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceDashboards_basic
=== PAUSE TestAccDataSourceDashboards_basic
=== CONT  TestAccDataSourceDashboards_basic
--- PASS: TestAccDataSourceDashboards_basic (87.92s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/aom       88.169s

make testacc TEST="./huaweicloud/services/acceptance/aom" TESTARGS="-run TestAccDashboardsFolder_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/aom -v -run TestAccDashboardsFolder_basic -timeout 360m -parallel 4
=== RUN   TestAccDashboardsFolder_basic
=== PAUSE TestAccDashboardsFolder_basic
=== CONT  TestAccDashboardsFolder_basic
--- PASS: TestAccDashboardsFolder_basic (118.81s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/aom       118.871s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@saf3dfsa saf3dfsa force-pushed the feat(aom)_support_dashboard_management branch from 9a785cf to a4ec524 Compare August 13, 2024 12:10
@saf3dfsa saf3dfsa force-pushed the feat(aom)_support_dashboard_management branch from a4ec524 to 501b8db Compare August 14, 2024 02:24
@saf3dfsa saf3dfsa force-pushed the feat(aom)_support_dashboard_management branch 8 times, most recently from 5dd25db to 5ea3a45 Compare August 19, 2024 06:52
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Aug 19, 2024
@saf3dfsa saf3dfsa force-pushed the feat(aom)_support_dashboard_management branch from 5ea3a45 to b898dc6 Compare August 19, 2024 09:30
@github-ci-robot github-ci-robot removed the LGTM /lgtm label Aug 19, 2024
@saf3dfsa saf3dfsa force-pushed the feat(aom)_support_dashboard_management branch 2 times, most recently from 74bc6f4 to d45a705 Compare August 21, 2024 01:47
@houpeng80
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
github-ci-robot
github-ci-robot approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/approve

@saf3dfsa saf3dfsa force-pushed the feat(aom)_support_dashboard_management branch from d45a705 to 6d0984b Compare August 21, 2024 07:02
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Aug 21, 2024
@github-ci-robot github-ci-robot merged commit 485da5c into huaweicloud:master Aug 21, 2024
13 checks passed
@saf3dfsa saf3dfsa deleted the feat(aom)_support_dashboard_management branch November 14, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saf3dfsa @Jason-Zhang9309 @houpeng80 @github-ci-robot