Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secmaster): add datasource incidents #5394

Merged

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Aug 14, 2024

What this PR does / why we need it:
add datasource incidents

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add datasource incidents

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/secmaster' TESTARGS='-run TestAccDataSourceIncidents_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/secmaster -v -run TestAccDataSourceIncidents_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceIncidents_basic
=== PAUSE TestAccDataSourceIncidents_basic
=== CONT  TestAccDataSourceIncidents_basic
--- PASS: TestAccDataSourceIncidents_basic (35.93s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/secmaster 35.989s
  • Documentation updated.
  • Schema updated.
  • CheckDeleted.

@luoping-12345 luoping-12345 force-pushed the secmaster_incidents branch 3 times, most recently from fb8bcd9 to 30c3172 Compare August 16, 2024 01:50
@luoping-12345 luoping-12345 changed the title [WIP] feat(secmaster): add datasource incidents feat(secmaster): add datasource incidents Aug 16, 2024
@luoping-12345 luoping-12345 force-pushed the secmaster_incidents branch 2 times, most recently from 6855a25 to 21d6d16 Compare August 16, 2024 02:01
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Aug 16, 2024
@github-ci-robot github-ci-robot removed the LGTM /lgtm label Aug 19, 2024
@Jason-Zhang9309
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit 409c304 into huaweicloud:master Aug 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants