-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secmaster): add datasource incidents #5394
Merged
github-ci-robot
merged 1 commit into
huaweicloud:master
from
luoping-12345:secmaster_incidents
Aug 19, 2024
Merged
feat(secmaster): add datasource incidents #5394
github-ci-robot
merged 1 commit into
huaweicloud:master
from
luoping-12345:secmaster_incidents
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoping-12345
force-pushed
the
secmaster_incidents
branch
3 times, most recently
from
August 16, 2024 01:50
fb8bcd9
to
30c3172
Compare
luoping-12345
changed the title
[WIP] feat(secmaster): add datasource incidents
feat(secmaster): add datasource incidents
Aug 16, 2024
luoping-12345
force-pushed
the
secmaster_incidents
branch
2 times, most recently
from
August 16, 2024 02:01
6855a25
to
21d6d16
Compare
houpeng80
reviewed
Aug 16, 2024
huaweicloud/services/secmaster/data_source_huaweicloud_secmaster_incidents.go
Outdated
Show resolved
Hide resolved
luoping-12345
force-pushed
the
secmaster_incidents
branch
from
August 16, 2024 03:48
21d6d16
to
31aab85
Compare
/lgtm |
huaweicloud/services/secmaster/data_source_huaweicloud_secmaster_incidents.go
Outdated
Show resolved
Hide resolved
luoping-12345
force-pushed
the
secmaster_incidents
branch
from
August 19, 2024 02:18
31aab85
to
397194a
Compare
/lgtm |
github-ci-robot
added
LGTM
/lgtm
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Aug 19, 2024
github-ci-robot
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been approved by: @Jason-Zhang9309
/lgtm
/approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add datasource incidents
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist