-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(eg/channel): deprecate the channel_id filter and refactor the resource codes #5399
refactor(eg/channel): deprecate the channel_id filter and refactor the resource codes #5399
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
eec76e5
to
0e4f161
Compare
make testacc TEST='./huaweicloud/services/acceptance/eg' TESTARGS='-run=TestAccDataCustomEventChannels_' |
huaweicloud/services/eg/data_source_huaweicloud_eg_custom_event_channels.go
Outdated
Show resolved
Hide resolved
0e4f161
to
a7bebaf
Compare
|
/lgtm |
What this PR does / why we need it:
The API document has offline the channel_id parameter, so, we mark it as deprecated and remove it from the markdown file definition.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<