Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eg/channel): deprecate the channel_id filter and refactor the resource codes #5399

Merged

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
The API document has offline the channel_id parameter, so, we mark it as deprecated and remove it from the markdown file definition.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. deprecate the channel_id filter

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/eg' TESTARGS='-run=TestAccDataCustomEventChannels_filterById'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/eg -v -run=TestAccDataCustomEventChannels_filterById -timeout 360m -parallel 4
=== RUN   TestAccDataCustomEventChannels_filterById
=== PAUSE TestAccDataCustomEventChannels_filterById
=== CONT  TestAccDataCustomEventChannels_filterById
--- PASS: TestAccDataCustomEventChannels_filterById (37.01s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/eg        37.113s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 changed the title chore(eg/channel): deprecate the channel_id filter refactor(eg/channel): deprecate the channel_id filter and refactor the resource codes Aug 15, 2024
@Lance52259 Lance52259 force-pushed the br_eg_event_channels_refactor branch from eec76e5 to 0e4f161 Compare August 15, 2024 08:08
@Lance52259
Copy link
Contributor Author

make testacc TEST='./huaweicloud/services/acceptance/eg' TESTARGS='-run=TestAccDataCustomEventChannels_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/eg -v -run=TestAccDataCustomEventChannels_ -timeout 360m -parallel 4
=== RUN TestAccDataCustomEventChannels_basic
=== PAUSE TestAccDataCustomEventChannels_basic
=== RUN TestAccDataCustomEventChannels_filterById
=== PAUSE TestAccDataCustomEventChannels_filterById
=== RUN TestAccDataCustomEventChannels_filterByEpsId
=== PAUSE TestAccDataCustomEventChannels_filterByEpsId
=== CONT TestAccDataCustomEventChannels_basic
=== CONT TestAccDataCustomEventChannels_filterByEpsId
=== CONT TestAccDataCustomEventChannels_filterById
--- PASS: TestAccDataCustomEventChannels_filterByEpsId (51.88s)
--- PASS: TestAccDataCustomEventChannels_filterById (59.43s)
--- PASS: TestAccDataCustomEventChannels_basic (61.23s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/eg 61.301s

@Lance52259 Lance52259 force-pushed the br_eg_event_channels_refactor branch from 0e4f161 to a7bebaf Compare August 16, 2024 03:19
@Lance52259
Copy link
Contributor Author

image

@Lance52259
Copy link
Contributor Author

../coverage.sh -o eg -f TestAccDataCustomEventChannels
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/eg" -v -coverprofile="./huaweicloud/services/acceptance/eg_coverage.cov" -coverpkg="./huaweicloud/services/eg" -run TestAccDataCustomEventChannels -timeout 360m -parallel 10
=== RUN   TestAccDataCustomEventChannels_basic
=== PAUSE TestAccDataCustomEventChannels_basic
=== RUN   TestAccDataCustomEventChannels_filterById
=== PAUSE TestAccDataCustomEventChannels_filterById
=== RUN   TestAccDataCustomEventChannels_filterByEpsId
=== PAUSE TestAccDataCustomEventChannels_filterByEpsId
=== CONT  TestAccDataCustomEventChannels_basic
=== CONT  TestAccDataCustomEventChannels_filterByEpsId
=== CONT  TestAccDataCustomEventChannels_filterById
--- PASS: TestAccDataCustomEventChannels_filterByEpsId (53.64s)
--- PASS: TestAccDataCustomEventChannels_filterById (58.65s)
--- PASS: TestAccDataCustomEventChannels_basic (60.52s)
PASS
coverage: 13.1% of statements in ./huaweicloud/services/eg
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/eg        60.585s coverage: 13.1% of statements in ./huaweicloud/services/eg

@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Aug 16, 2024
@github-ci-robot github-ci-robot merged commit 0d56926 into huaweicloud:master Aug 16, 2024
13 checks passed
@Lance52259 Lance52259 deleted the br_eg_event_channels_refactor branch August 16, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants