Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cbr/policy): enable_acceleration is an internal param now #6084

Conversation

Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Dec 24, 2024

What this PR does / why we need it:
Update the behavior of parameter enable_acceleration from public optional to internal optional.
Because the permission OP_GATED_CSBS_REP_ACCELERATION cannot be disabled on the custom side.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. update the behavior of parameter enable_acceleration from public optional to internal optional.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o cbr -f TestAccPolicy
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cbr" -v -coverprofile="./huaweicloud/services/acceptance/cbr/cbr_coverage.cov" -coverpkg="./huaweicloud/services/cbr" -run TestAccPolicy -timeout 360m -parallel 10
=== RUN   TestAccPolicy_basic
=== PAUSE TestAccPolicy_basic
=== RUN   TestAccPolicy_retention
=== PAUSE TestAccPolicy_retention
=== RUN   TestAccPolicy_replication
=== PAUSE TestAccPolicy_replication
=== CONT  TestAccPolicy_basic
=== CONT  TestAccPolicy_replication
=== CONT  TestAccPolicy_retention
--- PASS: TestAccPolicy_replication (12.74s)
--- PASS: TestAccPolicy_basic (20.61s)
--- PASS: TestAccPolicy_retention (20.91s)
PASS
coverage: 14.3% of statements in ./huaweicloud/services/cbr
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cbr       20.982s coverage: 14.3% of statements in ./huaweicloud/services/cbr
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 24, 2024
@github-ci-robot github-ci-robot merged commit 5ca869e into huaweicloud:master Dec 24, 2024
20 checks passed
@Lance52259 Lance52259 deleted the br_cbr_policy_enable_acceleration_adjust branch December 25, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants