Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live/origin_pull_configuration): support origin pull configuration resource #6085

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Dec 24, 2024

What this PR does / why we need it:

Support origin pull configuration resource

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


Support origin pull configuration resource

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccOriginPullConfiguration_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccOriginPullConfiguration_basic -timeout 360m -parallel 4
=== RUN   TestAccOriginPullConfiguration_basic
=== PAUSE TestAccOriginPullConfiguration_basic
=== CONT  TestAccOriginPullConfiguration_basic
--- PASS: TestAccOriginPullConfiguration_basic (204.53s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      204.575s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found

      ab. Related resources (parent resources) not found

When the domain_name does not exist.
image

  • b. During delete/disassociate/unbind operation (Delete Context)
    ba. Resource not found
    >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222 jinyangyang222 force-pushed the feat-live/support-origin_pull_configuration branch 2 times, most recently from d5e9aae to 13e5322 Compare December 24, 2024 13:00
@jinyangyang222 jinyangyang222 force-pushed the feat-live/support-origin_pull_configuration branch from 13e5322 to f611456 Compare December 25, 2024 02:33
@jinyangyang222 jinyangyang222 force-pushed the feat-live/support-origin_pull_configuration branch from f611456 to 7d926c9 Compare December 25, 2024 03:30
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 25, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 3f81e89 into huaweicloud:master Dec 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants