Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): add new datasource to query live channels #6090

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Dec 25, 2024

What this PR does / why we need it:

add new datasource to query live channels

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/live' TESTARGS='-run TestAccDataSourceChannels_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccDataSourceChannels_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceChannels_basic
=== PAUSE TestAccDataSourceChannels_basic
=== CONT  TestAccDataSourceChannels_basic
--- PASS: TestAccDataSourceChannels_basic (12.03s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      12.076s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@deer-hang deer-hang force-pushed the feat-datasource-live-channels branch from 9d4d3ea to f089a7a Compare December 25, 2024 07:27
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@deer-hang deer-hang force-pushed the feat-datasource-live-channels branch from f089a7a to f50a8ba Compare December 25, 2024 07:35
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 25, 2024
@github-ci-robot github-ci-robot merged commit 713b8ea into huaweicloud:master Dec 25, 2024
16 checks passed
@deer-hang deer-hang deleted the feat-datasource-live-channels branch December 25, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants