Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): live domain resource support new field is_ipv6 #6095

Merged

Conversation

deer-hang
Copy link
Contributor

What this PR does / why we need it:

live domain resource support new field is_ipv6

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
go test -v -coverprofile=coverage_1735183334773_TestAccDomain_basic.cov -coverpkg=./huaweicloud/services/live ./huaweicloud/services/acceptance/live -run TestAccDomain_basic -timeout 360m -parallel 4
=== RUN   TestAccDomain_basic
--- PASS: TestAccDomain_basic (390.59s)
PASS
coverage: 10.0% of statements in ./huaweicloud/services/live
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      390.646s        coverage: 10.0% of statements in ./huaweicloud/services/live

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang
Copy link
Contributor Author

make testacc TEST='./huaweicloud/services/acceptance/live' TESTARGS='-run TestAccDomain_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccDomain_basic -timeout 360m -parallel 4
=== RUN   TestAccDomain_basic
--- PASS: TestAccDomain_basic (482.38s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      482.426s

@deer-hang deer-hang force-pushed the chore-live-domain-resource branch from 87c4284 to 40f5fa8 Compare December 26, 2024 06:32
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 26, 2024
@github-ci-robot github-ci-robot merged commit 4e33749 into huaweicloud:master Dec 26, 2024
13 checks passed
@deer-hang deer-hang deleted the chore-live-domain-resource branch December 26, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants