feat(CodeArts/Deploy): support to copy application #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
This PR needs rebase. |
saf3dfsa
force-pushed
the
feat(CodeArts/Deploy)_support_to_copy_application
branch
from
e3cb95d to
20c7246
Compare
saf3dfsa
force-pushed
the
feat(CodeArts/Deploy)_support_to_copy_application
branch
2 times, most recently
from
3320864 to
66041a8
Compare
houpeng80
reviewed
Jan 17, 2025
| } | ||
|
|
||
| if _, ok := d.GetOk("permission_level"); ok { | ||
| if err := updateDeployApplicationPermissionLevel(ctx, client, d, d.Timeout(schema.TimeoutUpdate)); err != nil { |
There was a problem hiding this comment.
Suggested change
| if err := updateDeployApplicationPermissionLevel(ctx, client, d, d.Timeout(schema.TimeoutUpdate)); err != nil { | |
| if err := updateDeployApplicationPermissionLevel(ctx, client, d, d.Timeout(schema.TimeoutCreate)); err != nil { |
| Importer: &schema.ResourceImporter{ | ||
| StateContext: schema.ImportStatePassthroughContext, | ||
| }, | ||
|
|
There was a problem hiding this comment.
timeouts should be added
saf3dfsa
force-pushed
the
feat(CodeArts/Deploy)_support_to_copy_application
branch
from
66041a8 to
605f4fa
Compare
|
/lgtm |
github-ci-robot
added
LGTM
github-ci-robot
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
support to copy application
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<