Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfw): add this data source to get the list of CFW tags #6160

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

profoundwu
Copy link
Contributor

What this PR does / why we need it:
add this data source to get the list of CFW tags
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add this data source to get the list of CFW tags

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/cfw" TESTARGS="-run TestAccDataSourceC
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cfw -v -run TestAccDataSourceCfwTags_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCfwTags_basic
=== PAUSE TestAccDataSourceCfwTags_basic
=== CONT  TestAccDataSourceCfwTags_basic
--- PASS: TestAccDataSourceCfwTags_basic (16.11s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cfw       16.192s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@Alice1319
Copy link

LGTM

1 similar comment
@dengyali0125
Copy link

LGTM

@WangLiNaruto
Copy link

LGTM

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 8, 2025
@luoping-12345
Copy link
Contributor

LGTM

@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit e6b5e18 into huaweicloud:master Jan 9, 2025
14 checks passed
@profoundwu profoundwu deleted the feat_cfw_tags branch January 9, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants