Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(live): refactor the Live domain resource code style #6166

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

Refactor the Live domain resource code style

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccResourceDomain_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccResourceDomain_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceDomain_basic
--- PASS: TestAccResourceDomain_basic (347.22s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      347.308s
$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccResourceDomain_streamDomain"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccResourceDomain_streamDomain -timeout 360m -parallel 4
=== RUN   TestAccResourceDomain_streamDomain
--- PASS: TestAccResourceDomain_streamDomain (580.18s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      580.257s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image
    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@Alice1319
Copy link

LGTM

@ruwenqiang123 ruwenqiang123 force-pushed the dev_domain branch 2 times, most recently from 3558114 to 7d31bb4 Compare January 9, 2025 08:34
@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccResourceDomain_streamDomain"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccResourceDomain_streamDomain -timeout 360m -parallel 4
=== RUN   TestAccResourceDomain_streamDomain
--- PASS: TestAccResourceDomain_streamDomain (402.82s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      402.866s

@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccResourceDomain_streamDomain"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccResourceDomain_streamDomain -timeout 360m -parallel 4
=== RUN   TestAccResourceDomain_streamDomain
--- PASS: TestAccResourceDomain_streamDomain (313.39s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      313.442s

@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccResourceDomain_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccResourceDomain_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceDomain_basic
--- PASS: TestAccResourceDomain_basic (362.78s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      362.834s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 74c0157 into huaweicloud:master Jan 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants