Update Workflows #55
Merged
Update Workflows #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsweger
reviewed
Sep 24, 2024
| run: | | ||
| # remove the remote declarations from the DESCRIPTION so that we | ||
| # test the released version | ||
| sed -i -e '/ hubverse-org/d' DESCRIPTION |
There was a problem hiding this comment.
For my own understanding: if there's a hotfix/release for this package (hubEvals), why do we need to remove the remote references for dependencies like hubUtils?
There was a problem hiding this comment.
This is because these packages are in the Remotes: field, which will pull the development versions of the packages when standing up the infrastructure for testing (see https://r-pkgs.org/dependencies-in-practice.html#depending-on-the-development-version-of-a-package).
By removing these from the DESCRIPTION, we force the workflow to pull the released versions of the dependent packages.
elray1
approved these changes
Sep 24, 2024
Co-authored-by: Evan Ray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update workflows for universe release (to be merged after release)