fix transform_pmf_model_out #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was introduced in epiforecasts/scoringutils#915 and subsequently broke our tests.
A whole bunch of new warnings started popping up because scoringutils was trying to take the mean of character columns. Wrapping everything in `suppressWarnings()` helps.
elray1
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
modelargument from the call toscoringutils::as_forecast_nominal()as they removed that argument in epiforecasts/scoringutils#915Note that there were a bunch of "coercion to NA" warnings in the block of tests that checked for errors and warnings, so I wrapped them in
suppressWarning().This will fix #56