Indexed event param #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmittmann
requested changes
Oct 21, 2024
crates/ast/src/parser.rs
Outdated
| @@ -841,6 +849,34 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_sol_event_indexed() { | |||
There was a problem hiding this comment.
Let's keep the current schema of one test function with multiple assets per parser function
| @@ -341,6 +341,10 @@ fn sol_type<'tokens, 'src: 'tokens>() -> impl Parser<'tokens, 'src, Spanned<DynS | |||
| recursive(|sol_raw_type| { | |||
| let sol_raw_primitive_type = ident().map(|(typ, _)| typ.to_string()); | |||
|
|
|||
| let sol_raw_event_primitive_type = ident() | |||
There was a problem hiding this comment.
This would also allow indexed args inside tuples and inside function args. Maybe we should give the sol_type_parser a flag to enable "indexed" args.
There was a problem hiding this comment.
You're right, let me see how I can fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
indexedevent parameters when declared with#define.