Optimized sequence encoding for scalars #7393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #3197 introduced redundant list-comprehensions when
obj
is a long sequence of scalars. This becomes a noticeable overhead when loading data from anIterableDataset
in the function_apply_feature_types_on_example
and can be eliminated by adding a check for scalars inencode_nested_example
proposed here.In the following code example
encode_nested_example
becomes 492x faster (from 0.0769 to 0.0002 sec), respectively 322x (from 0.00814 to 0.00003 sec) for a list of length 10000, on a GH200 system, making it unnoticeable when loading data with tokenization.Another change is made to avoid creating arrays from scalars and afterwards re-extracting them during casting to python (
obj == obj.__array__()[()]
in that case), which avoids a regression in the array write benchmarks.