👀 Add Comfy UI #1005
Open
👀 Add Comfy UI #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaibhavs10
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
Vaibhavs10
commented
Oct 30, 2024
| repoName: "ComfyUI", | ||
| repoUrl: "https://github.com/comfyanonymous/ComfyUI", | ||
| filter: false, | ||
| countDownloads: `path_extension:"safetensors"`, |
There was a problem hiding this comment.
This will increase the download counts a bit - but unsure what should be the best way to track downloads otherwise.
If we use safetensors then it'd be same as the way we track multiple GGUFs in a repo.
Wauplin
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Just a few questions from a novice:
- What makes a repo a "ComfyUI" repo? Are all diffusers repo also compatible with ComfyUI or not?
- Should ComfyUI rather be considered as a Local App instead of a library or not really?
Otherwise, I'm ok with the PR. Makes sense to track downloads like this when safetensors are files are not related.
| repoName: "ComfyUI", | ||
| repoUrl: "https://github.com/comfyanonymous/ComfyUI", | ||
| filter: false, | ||
| countDownloads: `path_extension:"safetensors"`, |
Co-authored-by: Lucain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sample repos:
Not all of them have a JSON and some of them have different precision safetensors too.
To-Do:
Open PRs w/
Comfytag