Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gguf: update README #663

Merged
merged 2 commits into from
May 13, 2024
Merged

gguf: update README #663

merged 2 commits into from
May 13, 2024

Conversation

ngxson
Copy link
Member

@ngxson ngxson commented May 12, 2024

Follow up #655 and #656 (comment)

Added some examples on how to use local file + strictly typed

@ngxson ngxson requested review from mishig25 and julien-c as code owners May 12, 2024 09:34
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

BTW, if you want (not sure it makes sense for this particular change), there's also a doc page inside the Hub docs, here: https://huggingface.co/docs/hub/gguf

There's also a hosted doc for huggingface.js here in case this is useful in the future.

packages/gguf/README.md Outdated Show resolved Hide resolved
packages/gguf/README.md Outdated Show resolved Hide resolved
packages/gguf/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Looks great

Co-authored-by: Julien Chaumond <[email protected]>
Co-authored-by: Mishig <[email protected]>
@ngxson
Copy link
Member Author

ngxson commented May 13, 2024

BTW, if you want (not sure it makes sense for this particular change), there's also a doc page inside the Hub docs, here: https://huggingface.co/docs/hub/gguf

There's also a hosted doc for huggingface.js here in case this is useful in the future.

Thanks for the info. For now I don't think there's change from this particular PR that should be updated to the hosted docs, but in the future I will make updates if needed.

@mishig25 mishig25 merged commit 75f93d8 into huggingface:main May 13, 2024
3 of 4 checks passed
@mishig25
Copy link
Collaborator

Awesome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants