Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ModelCardData's datasets typing #2644

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix ModelCardData's datasets typing #2644

merged 1 commit into from
Oct 30, 2024

Conversation

hanouticelina
Copy link
Contributor

Fixes #2642.

Small PR to update ModelCardData.datasets type from Optional[List[str]] to Optional[Union[str, List[str]]] to match server-side ModelMetadata.datasets type (see here).

@hanouticelina hanouticelina mentioned this pull request Oct 29, 2024
Closed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Wauplin
Wauplin approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hanouticelina hanouticelina merged commit 8a99deb into main Oct 30, 2024
17 checks passed
@hanouticelina hanouticelina deleted the fix-ModelCardData-typing branch October 30, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent API format for ModelDataCard
3 participants
@hanouticelina @HuggingFaceDocBuilderDev @Wauplin