Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
Details
I found the first few manually in the README, and then found the rest via
codespell
.Note
There's another typo which seems more critical to the behaviour of the package, so I did not change that one:
optimum-benchmark/optimum_benchmark/benchmarks/training/benchmark.py
Line 53 in 90ad2ea
samles
should besamples
. Because of this, a bunch of the csv's also have thissamles
: https://github.com/huggingface/optimum-benchmark/blob/90ad2ea78d23ad59ef23ee9552a1c484706ec336/examples/training-llamas/experiments/A100-80GB/llama_peft%2Bbnb_batch_size(2)/1/training_results.csvI'll leave this one for you to fix, as I'm not sure how it all connects together.