Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support tensor parallelism with Deepspeed #87

Merged
merged 20 commits into from
Nov 23, 2023

Conversation

IlyasMoutawwakil
Copy link
Member

This PR adds support for tensor parallelism by using deepspeed and torchrun.

It comes with some refactoring to introduce a new set of objects called launchers, which allow us to customize how experiments are launched.

@IlyasMoutawwakil
Copy link
Member Author

Another thing that is changed in this PR is how we do isolation checks. AMD GPUs can't be perfectly isolated from one another, so a process running on GPU 0 will affect all other GPUs, so what we do is we create a torch.distributed.TCPStore where we put all the PIDs that are permitted on our GPUs. For now we use as much isolation processes as worker process, but we can reduce that to only one.

@IlyasMoutawwakil IlyasMoutawwakil merged commit 48a4410 into main Nov 23, 2023
13 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the deepspeed-inference branch April 30, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant