Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lm_eval issue of llama #1606

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix lm_eval issue of llama #1606

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d93bfa
fix lm_eval issue of llama
sywangyi Dec 13, 2024
00f269b
fmt
sywangyi Dec 13, 2024
0f1ee4e
Merge branch 'main' into lm_eval_llama
sywangyi Dec 13, 2024
65b8a7c
fmt
sywangyi Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions optimum/habana/transformers/models/llama/modeling_llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,15 +403,18 @@ def allocate(self, inp_seq_len, dtype, device, shape):

@staticmethod
def update(prev, cur, dim, idx, inp_seq_len):
orig_cur = cur
if prev.shape == cur.shape:
prev.copy_(cur)
return orig_cur
if idx is not None and cur.shape[2] > 1 and cur.shape[2] <= prev.shape[2]:
# Initialize
prev[:, :, :inp_seq_len, :].copy_(cur)
return orig_cur
if inp_seq_len != -1:
# reuse cache logic
orig_cur = cur
if prev.shape == cur.shape:
prev.copy_(cur)
return orig_cur
if cur.shape[2] > 1 and cur.shape[2] <= prev.shape[2]:
# Initialize
prev[:, :, :inp_seq_len, :].copy_(cur)
return orig_cur
if idx is not None:
# 2+ tokenizer logic if model is static shape optimized
prev.index_copy_(dim, idx - 1, cur)
return prev
else:
Expand Down Expand Up @@ -654,9 +657,11 @@ def pre_attn_forward(
past_value = torch.zeros(
key_states.shape, dtype=self.get_k_proj_weight_dtype(), device=key_states.device
)
past_key.copy_(key_states)
past_value.copy_(value_states)
# Return list instead of tuple
past_key_value = [past_key, past_value]
if (
elif (
token_idx is not None
and num_virtual_tokens is not None
and num_virtual_tokens == past_key_value[0].shape[-2]
Expand Down
Loading