-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the UNET custom attention processors #1608
Open
yafshar
wants to merge
2
commits into
huggingface:main
Choose a base branch
from
yafshar:image_generation_regression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace the the custom attention processors with the default implementation.
yafshar
changed the title
Replace the custom attention processors
Replace the UNET custom attention processors
Dec 13, 2024
Using this PR, the test passes on both G2 & G3 |
yeonsily
approved these changes
Dec 13, 2024
@imangohari1 I added your patch. Please add the test results. |
@regisss @astachowiczhabana @libinta PR #1545 added the p.s. upstream discussion: huggingface/diffusers#7300 G3
G2
G1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue) on G3
It sounds like that the UNET custom attention processors is the issue, if we replace it with the default implementation. The error goes away
This PR fixes the issue
>>> python -m pytest tests/test_diffusers.py -v -s -k test_deterministic_image_generation --junitxml=report4.xml -------------------------------------- generated xml file: /root/optimum-habana/report4.xml --------------------------------------- ======================================= 2 passed, 163 deselected, 4 warnings in 154.12s (0:02:34) ========================================
Before submitting