Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textual_inversion_sdxl failure on docker 1.20 #1697

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

atakaha
Copy link
Contributor

@atakaha atakaha commented Jan 14, 2025

Add device setting to torch.ones() to allocate tenser on target device

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@atakaha atakaha requested a review from regisss as a code owner January 14, 2025 22:09
@atakaha
Copy link
Contributor Author

atakaha commented Jan 14, 2025

@jiminha please review this PR. To pass pytest it needs "--sdx_on_bf16" enabling.

Copy link
Contributor

@dsocek dsocek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atakaha Please also update examples/stable-diffusion/training/textual_inversion.py with the same update

Add device setting to torch.ones() to allocate tenser on target device
@atakaha atakaha force-pushed the update_textual_inversion_sdxl branch from 8b75b5b to f63f36e Compare January 15, 2025 23:10
Copy link
Contributor

@dsocek dsocek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atakaha
Copy link
Contributor Author

atakaha commented Jan 15, 2025

@atakaha Please also update examples/stable-diffusion/training/textual_inversion.py with the same update

@dsocek applied the change to textual_inversion.py also.

@jiminha jiminha added the run-test Run CI for PRs from external contributors label Jan 17, 2025
@regisss regisss merged commit 8748077 into huggingface:main Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants