Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformers 4.48 #2158

Merged
merged 26 commits into from
Jan 29, 2025
Merged

Transformers 4.48 #2158

merged 26 commits into from
Jan 29, 2025
+272 −115

Conversation

IlyasMoutawwakil
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@IlyasMoutawwakil
Copy link
Member Author

huggingface/transformers#35791 is needed to fix is_causal being a tensor errors.

@IlyasMoutawwakil
Copy link
Member Author

Tensor Cache is proposed in https://github.com/huggingface/transformers/pull/35792/files

echarlaix
echarlaix approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks a lot @IlyasMoutawwakil 🔥

optimum/exporters/onnx/model_patcher.py Outdated Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Outdated Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Outdated Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Outdated Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Outdated Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Outdated Show resolved Hide resolved
echarlaix
echarlaix approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great PR @IlyasMoutawwakil

@IlyasMoutawwakil IlyasMoutawwakil merged commit d1bcdf7 into main Jan 29, 2025
37 of 39 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the transformers-4.48 branch January 29, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

@xenova xenova Awaiting requested review from xenova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyasMoutawwakil @echarlaix