Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Have PR) Speed up BeamScorer to make GPT-2 generation 2-3x faster #30647

Closed
fzyzcjy opened this issue May 4, 2024 · 5 comments
Closed

(Have PR) Speed up BeamScorer to make GPT-2 generation 2-3x faster #30647

fzyzcjy opened this issue May 4, 2024 · 5 comments

Comments

@fzyzcjy
Copy link
Contributor

fzyzcjy commented May 4, 2024

Feature request

Please refer to #21234 (comment) for details (I create a new issue because I guess the reply to ancient issue will not be seen)

Motivation

Your contribution

@amyeroberts
Copy link
Collaborator

cc @gante

@gante
Copy link
Member

gante commented May 14, 2024

Hi @fzyzcjy 👋

The reason for not merging your suggested PR is still valid, we are currently refactoring generate and beam_search will look very different from what it is at the moment when we're done :)

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented May 14, 2024

I see. May I know when will the refactor be done? (seems many months have passed...) and looking forward to the new code!

@gante
Copy link
Member

gante commented May 25, 2024

@fzyzcjy You can see the tracker here 🤗

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants