Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super tiny fix unused masked_bias #30235

Closed
wants to merge 1 commit into from
Closed

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Apr 13, 2024

What does this PR do?

Hi thanks for the library! When learning (thus reading source code) GPT2, it seems that the masked_bias is not used. I have searched this keyword in the lib and does not find usages as well. Thus I try to make this PR and see whether the removal still makes CI happy.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Indeed - it seems self.masked_bias was removed in #17306

As the buffer isn't persistent, removing shouldn't cause any breaking changes or warnings for the users.

@amyeroberts
Copy link
Collaborator

@fzyzcjy Running make fix-copies and pushing the changes should resolve failing the quality checks

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented May 14, 2024

Oops I forgot this... Will do it later when working with #30647

@huggingface huggingface deleted a comment from github-actions bot May 14, 2024
@huggingface huggingface deleted a comment from github-actions bot Jun 10, 2024
Copy link

github-actions bot commented Jul 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@amyeroberts
Copy link
Collaborator

@fzyzcjy Any update on this PR?

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jul 5, 2024

Sorry I do not have huggingface transformers environment locally and may not worth it to create one for this single-line PR...

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants