Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SuperGlue model #29886
Add SuperGlue model #29886
Changes from all commits
dfcac01
081efbf
b51ef54
78ff459
169c77c
11389f7
ffd3d76
875c291
e0fd6b9
355e57e
38a86b3
186d5f4
6237a36
fb7c58b
18e1818
33a0774
f516bea
4d12216
ca54def
113d8bf
77948ac
dd95fdd
006c49a
7e24e8a
6ba3350
4c1b67d
ff6808e
b67ce1b
0da244f
9fda942
f5cacf9
6556963
b68ba3d
2120390
e1810fb
774b371
9a527bb
c0f9aac
ba6c533
9adcfa4
a733666
2b6f777
61332fa
769d94a
798f9fe
1d7269e
d40210b
5920131
a726617
83a6422
a910b85
90fab40
d02b8b9
3e94f1f
417ce26
0d46d64
b2b7264
dc15c4a
00b4e5a
1bfd289
fc53366
b5cd46d
db4507f
866866d
8510749
9f269d9
7173ed8
3d77a20
0e4ab19
a794ade
10886a6
6982f80
dba1701
c6c69fa
af51f8f
1f5df27
d9cd67f
933b72d
7b5e21d
ec824b7
2a95cef
3e48daf
bdae04c
5dcf6f8
9793f4e
e25ab9d
95fb28f
3e8c974
7569107
3f79ae4
f9861cd
d96b0a8
f5dce0d
e270250
8172032
4f1ce85
5f8c347
8b9219e
c3ca4a1
ed47ed0
e7f36c5
b053497
e9a0120
6269f49
e788a02
d92adca
d76d28c
7691b83
0447476
2f924d7
60b9d3d
13ae18d
c6b1177
fe22517
bc97e7f
163dd04
243b2fb
aac8b22
f2fbe8a
84bb579
0faa7d2
b04cf00
de6a1d5
538404e
0d2825d
4c28182
f01f206
8f165da
c3773a5
c31e8e0
63121d8
7e5ac79
c928128
2233c1f
c98e2e2
d899649
60c1536
061918f
ff94a08
8ea374d
e9c5483
5534cb4
f8f5dd7
9ede8fa
777ff09
732d964
55bfdb9
9c237c9
02fd468
d34af9e
ef6241b
a802ead
ea566d6
d4dbf2e
92e8894
7e2687c
8694cd5
2ace6a6
8289e25
b395999
bc0a691
4938770
fd6a01b
e906750
97cf682
0ad7f2d
63ff94f
53d37dd
fb7cdc5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it would make sense to add this to the image processor / processor ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like a
plot_keypoint_matching(images, keypoint_matching_output, path)
method ? or just as a docstring ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah a method sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought a bit about this but I think it depends on whether you want to put visualization forward in the library or not. Here in this example we assume only a pair of images, but as a method in the processor, should it handle multiple pairs like other methods ? If so, should we visualize the pairs individually / all together ? In terms of plotting, should we force the template we have here or allow some customization ?
On the other hand, I don't know your policy about that, but on this SuperPoint's PR, another contributor took the opportunity of us introducing the new keypoint detection task to implement visualization in roboflow/supervision (PR still under work in progress as it appears), maybe it could also be the case for keypoint matching ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have
matplotlib
dependency? otherwise, I would better just provide snippets in docs and model card (as we have right now)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be considered as resolved ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we could have a soft dependency as well