🚨🚨🚨 Delete conversion scripts when making release wheels #35296
Merged
+19
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
release.py
to delete model conversion scripts. These scripts are generally included with specific model classes to convert checkpoints in non-Transformers formats. Often these scripts have to open insecure file types, because those were the file types the model was released with (e.g.pickle
or old Torch.bin
checkpoints). This results in vulnerability scanners flagging us, and can cause compliance issues for users.We don't see this as a serious attack vector in practice because users would have to be induced to download a malicious file and call an obscure conversion script on it, but excluding these files from release wheels should help with compliance issues!
Fixes #34840