-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Doge model #35891
base: main
Are you sure you want to change the base?
Add Doge model #35891
Conversation
This reverts commit 229cdca.
Hi @LoserCheems, and thanks for the PR! The model looks cool and I like the paper too, but we're trying to add new models using modular in future. You can see a guide here, and an example modular PR here. If you write |
Thank you @Rocketknight1 , I've written |
Hi @LoserCheems yes, don't worry, it's a new feature so everyone is a bit confused about it! 😅 Your Classes like |
Thank you @Rocketknight1. In fact, because the weight name or config name is different, can directly inherited class is not much, a total of |
Hi @LoserCheems, the last code quality error is caused by an unprotected There are unrelated failing tests under |
Sorry @Rocketknight1, I mistakenly imported |
em🤓, There seems to be something wrong with |
gentle ping @Rocketknight1 |
@Rocketknight1 code quality is already green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I made a couple more comments, and sorry for the delay! I think this is quite close to being ready, but there's some more code that could be removed from the modular
file, and that'll make it easier for the core maintainers to review later. I've flagged a couple of examples - you can ping me after you clean that up (or if it turns out I'm wrong and you can't import those methods from elsewhere), and I'll get a core maintainer to do a final review
Thank you @Rocketknight1 for your suggestion, I have finished the modification according to the suggestion! |
Yes, looks good to me now! cc @Cyrilvallez @ArthurZucker for core maintainer review. Failing tests are unrelated, should be fixed by rebasing after review / fixing nits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Thank you @ArthurZucker for your careful review. I have finished the modification according to your suggestion. |
This leads to incorrect weight initialization.
What does this PR do?
Fixes #35889
Support the Doge-SLM family of small language models.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
to: @ArthurZucker