Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat template: update for processor #35953

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zucchini-nlp
Copy link
Member

@zucchini-nlp zucchini-nlp commented Jan 29, 2025

What does this PR do?

CI will be red until #35558 is merged, we need batched support for all VLMs. But feel free to take a first review, anyone who wants :)

This PR adds:

  • Support for batched inputs, which I forgot to add the last time
  • Tiny hack for add_special_tokens as per @Rocketknight1's request
  • More tests for chat templates in the Mixin, so we don't write the same test per model. Note that for test to run, we need to have the correct chat_template in processor, not a dummy one

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants