-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs outdated & Beginning French docs translation #235
Conversation
Hi @hossainemruz, Do you see my MR ? It's seems that no. |
Hi @niltied ! Thank you for the PR. Sorry, didn't replied earlier. Going through some busy days. |
Oh @hossainemruz, I understand. I'm sorry. Take your time and when you're ready, don't hesitate to give me your feedback. See you later ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @niltied for this great PR. Almost looks good. Just few small changes necessary. Can you please check the comments and fix them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File updated
I'm not used to making MRs on Github. I reviewed the 2 files. I have updated my repo, but I don't know if I should do anything else afterwards with this MR. Can you check that it's OK for you? Thank, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @niltied
Hi @hossainemruz,
The content of this MR below :