Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs outdated & Beginning French docs translation #235

Merged
merged 23 commits into from
Dec 9, 2023

Conversation

niltied
Copy link
Contributor

@niltied niltied commented Nov 26, 2023

Hi @hossainemruz,

The content of this MR below :

  1. Update of article "Prepare your site" outdated, mainly block code and hugo version
  2. Addition of the first batch of articles from the doc translated into French, like :
  • Features/index.fr.md
  • Quickstart/index.fr.md
  • Shortcodes/index.fr.md
  • Supports/index.fr.md
  • Getting-started/prepare-site/index.fr.md
  • Getting-started/github_pages/index.fr.md
  • Getting-started/netlify/index.fr.md

@niltied
Copy link
Contributor Author

niltied commented Dec 2, 2023

Hi @hossainemruz,

Do you see my MR ? It's seems that no.

@hossainemruz
Copy link
Member

Hi @niltied ! Thank you for the PR. Sorry, didn't replied earlier. Going through some busy days.

@niltied
Copy link
Contributor Author

niltied commented Dec 2, 2023

Oh @hossainemruz, I understand. I'm sorry. Take your time and when you're ready, don't hesitate to give me your feedback.

See you later !

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied for this great PR. Almost looks good. Just few small changes necessary. Can you please check the comments and fix them?

README.md Outdated Show resolved Hide resolved
content/posts/supports/index.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@niltied niltied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File updated

@niltied
Copy link
Contributor Author

niltied commented Dec 9, 2023

@hossainemruz ,

I'm not used to making MRs on Github. I reviewed the 2 files. I have updated my repo, but I don't know if I should do anything else afterwards with this MR. Can you check that it's OK for you?

Thank,

@hossainemruz hossainemruz self-requested a review December 9, 2023 16:44
Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied

@hossainemruz hossainemruz merged commit 60fe3ad into hugo-toha:main Dec 9, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants